Hi Morgan! Morgan Smith <[email protected]> writes: > I imagine you'll be excited to hear that this patch series is being > worked on again! We wanted to share the following with you:
Yes, I am! Thanks. > Ihor Radchenko <[email protected]> writes: > >> Morgan Smith <[email protected]> writes: >> >>> If the compat team is listening, org currently defines compatibility >>> wrappers around the following items and it would be nice if they got >>> added to compat (no pressure, just thought I'd ask): >>> >>> display-buffer-full-frame >>> buffer-text-pixel-size >>> with-undo-amalgamate >>> time-convert >>> with-connection-local-variables >> >> We can ask Daniel. We can add missing functions to Compat. However we have been hesitant to backport pixel size computation functions since they are not as reliable as the originals and can affect packages negatively performance-wise. I had backported string-pixel-width at some point and it broke some packages. > Org is happy to define these things in our "org-compat.el" file which we > will not be getting rid of. However, please feel free to steal our > implementations so we can lighten the file a little. Sure, the file will have to stay since you probably backport much more, Org-specific functionality. Nevertheless I think you can cut out a lot. An important advantage is also that you can get rid of the org-* function name prefix and use the original names. >>> Is the a way to conditionally include compat so newer Emacs are not bogged >>> down? >> >> Could you elaborate? >> We can simply check if something like compat-31 is available, but I am >> not sure what the problem is. >> > > Sorry. I was trying to summarize all the previous discussions and > respond to everything. Someone had asked if there would be a > performance penality on Emacs that don't require compat. Since newer > emacs have a stub implementation of compat there should be no > performance impacts. No performance penalty! It is a guarantee. Older Emacs versions will use the Compat backports and they might not be as fast as the originals, but of course we try our best. Daniel
