Morgan Smith <[email protected]> writes: >> Thanks! >> Looks reasonable in general. >> I think we also need to update Package-Requires. > > I'm pretty sure I did that in the patch "Add compat.el dependency"
Oops. Somehow missed that. > -(defconst org-dependencies '() > +(defconst org-dependencies '((compat . (31))) > "An alist of dependencies of org. > Each item is of the form (PACKAGE . MINIMUM-VERSION).") This one is awkward, as it needs to be kept in sync with main package requirements. May we use `lm-package-requires' to ingest the requirements from org.el headers? I also tested the patch and ran into two issues: 1. emacs-28 has issues with elpa signature make uppkg EMACS=emacs-28 ========= Installing required third-party packages emacs-28 -Q --eval '(setq vc-handled-backends nil org-startup-folded nil org-element-cache-persistent nil)' --eval '(make-directory "/home/yantar92/Git/org-mode/pkg-deps/28.2" t)' --eval '(setq package-user-dir "/home/yantar92/Git/org-mode/pkg-deps/28.2")' -f package-initialize -batch --eval '(add-to-list `load-path "./lisp")' --eval '(load "../mk/org-dependencies.el")' \ -f org-install-dependencies Loading /home/yantar92/Git/org-mode/mk/org-dependencies.el (source)... Importing package-keyring.gpg... Importing package-keyring.gpg...done Contacting host: elpa.gnu.org:443 Contacting host: elpa.gnu.org:443 Failed to download ‘gnu’ archive. Contacting host: elpa.nongnu.org:443 Package refresh done Failed to download ‘nongnu’ archive. Importing package-keyring.gpg... Importing package-keyring.gpg...done Failed to download ‘gnu’ archive. Contacting host: elpa.nongnu.org:443 Package refresh done Failed to download ‘nongnu’ archive. Setting ‘package-selected-packages’ temporarily since "emacs -q" would overwrite customizations Setting ‘package-selected-packages’ temporarily since "emacs -q" would overwrite customizations Debugger entered--Lisp error: (error "Package ‘compat-’ is unavailable") We may or may not address this particular problem - Emacs 31 release is within reach, so Emacs 28 support will be dropped sooner rather than later. 2. make repro does not work even after make uppkg EMACS=emacs-29 make repro EMACS=emacs-29 will run make cleanall, so it fails all the time. Maybe we should run make uppkg as a part of make repro, but that will download things automatically, so maybe we should do it somehow differently. For example, make repro may skip cleanpkg. Otherwise, the patch looks good. -- Ihor Radchenko // yantar92, Org mode maintainer, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
