Pedro Andres Aranda Gutierrez <[email protected]> writes:
>> > "Additionally, ... also" sounds strange. Again, this is minor.
>>
>> You did not address this comment.
>>
> You said is was minor, so I ignored it... Anyhow, I've rewritten the
> sentence...
I see. From my perspective, the problem is not that you did not change
the patch, but that it was not clear to me if you just missed the
comment or decided not to address it. So, I had to go through my
previous message and double-check if other things were not missed.
If you can, please give a short statement about each comment, even if
you decide not to address it. You already do it in most cases.
> Subject: ox-beamer.el: add ltx-talk support
The new version of the patch does not pass the tests.
Please fix the failures.
> * lisp/ox-beamer.el top level: add ltx-class to org-latex-classes.
*ltx-talk
This typo is in multiple places, including the manual.
> +- =LATEX_CLASS= ::
> +
> + #+cindex: @samp{SUBTITLE}, keyword
*@samp{LATEX_CLASS}
> - (not (cl-some (lambda (s) (string-match-p "^label=" s))
> + (not (cl-some (lambda (s) (string-match-p (concat "^"
> label-str "=" s)))
*(string-match-p (concat "^" label-str "=") s)
Two arguments, not one.
Also, (regexp-quote label-str) is probably safer.
--
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
