Pedro Andres Aranda Gutierrez <[email protected]> writes:

>> *(string-match-p (concat "^" label-str "=") s)
>> Two arguments, not one.
>>
> Got me in this...

Doing make test and looking at the warnings would reveal it early.

>> Also, (regexp-quote label-str) is probably safer.
>
> Really? Looking at a quick test in my scratch buffer:
> ```
> (string-match-p
>  (regexp-quote (concat "^" "name" "="))
>  "name=pepe")
> nil
> (string-match-p
>  (concat "^" "name" "=")
>  "name=pepe")
> 0
> ```

I meant (concat "^" (regexp-quote "name") "=").
I went with it in the commit.

> Subject: ox-beamer.el: add ltx-talk support

Applied, onto main, with amendments.
I have added regexp-quote + fixed formatting and typos in the commit message.
I also fixed one failing test - your tests triggered duplicate detector.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=13a25caeb

-- 
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Reply via email to