>> Does this mean I should stop updating >> https://github.com/karthink/org-mode/tree/org-latex-preview and work on >> feature/org-latex-preview on Savannah instead? I don't have push >> privileges for the Org mode repo on Savannah. > > What I did is a merge commit + a couple of fixes on top of your existing > branch. You can start from that point, setting upstream to savannah.
I've switched to the "feature/org-latex-preview" branch in my remote tracking savannah's branch of the same name: https://github.com/karthink/org-mode/tree/feature/org-latex-preview Please fetch from here going forward. >>> ox-html is problematic though. It will require more careful review on my >>> side. >> >> Except for the LaTeX images HTML export options, there should be no >> changes to ox-html. Is there something you want me to look at? > > There are a couple of notes I have to look into: > 1. There are still some mentions of inlining images in the ORG-NEWS Removed in 448c63a9c47c46071740c4db71e18503cb13b9cf. > 2. :alt handling on the branch likely has a regression vs main > > #+begin_src emacs-lisp > (list :src source > - :alt (if (string-match-p > - (concat "^" org-preview-latex-image-directory) source) > - (org-html-encode-plain-text > - (org-find-text-property-in-string 'org-latex-src > source)) > - (file-name-nondirectory source))) > + :alt (file-name-nondirectory source)) > > #+end_src Not a regression. On main, org-html--format-image is used for generating the code for all images, including LaTeX preview images. In org-latex-preview, we use a dedicated function org-html-latex-image for this. The deleted branch in that :alt specifier is never reached. > 3. Several tests are failing Will address in a follow-up email. > 4. ox-html changes are vast and seemingly introduce a number of > regression. At least, I saw some features removed on the branch > compared to main but no alternative version is implemented on the > branch. Handing org-html--unlabel-latex-environment is one of them, > but I saw more yesterday and concluded that more careful review is > needed to not miss more. My understanding is that org-html--unlabel-latex-environment is not needed anymore since org-latex-preview handles equation numbering. In particular, the equation numbers are now part of the preview images. Formulas across the entire document/export region are handled in a single run by org-latex-preview, so consistent numbers are assigned to all the formulas. I see that org-html--unlabel-latex-environment is still present with no uses. I can remove it if you want, or you can let me know if some other solution is desired here. Please let me know what other issues you see in ox-html. Of the three you've reported so far: 1. Previously discussed change to captions Timothy made: I don't know, sorry. 2. Image :alt handling: Not a bug. 3. org-html--unlabel-latex-environment: Unused function now but no bug. > I will have limited free time until next weekend, so I will not be able > to work on the review actively in the coming days. Likewise. Unfortunately I also don't have the time to change any problematic behaviors introduced by org-latex-preview, unless it's possible to remove them entirely from the patchset. Karthik
