I did not understand you were talking about two independent patches.
I thought you had written two versions of the same patch--and
installed one of them.
I think I agree now that the patch you installed is a bug fix
and correct.
My patch tries to make save-window-excursion behave more like select-window
(and save-selected-window, and with-selected-window).
That is not concrete. Would you please document in a concrete
fashion the behavior that you believe your patch will achieve?
> Some uses of save-window-excursion expect to do (goto-char ...) inside
> the save-window-excursion and have point still be at that place
> outside the save-window-excursion. That's the kind of case that this
> patch could break.
Could you give an example where that would happen?
No, but someone would need to check for them in order to determine
whether this change would cause a problem.
Which problem?
The problem that point moves after
(save-window-excursion (select-window (next-window)))
That's the problem I saw reported.
I'm saying that changing it to
(save-excursion (save-window-excursion (select-window (next-window))))
ought to solve the problem too, and the approach is less risky.
_______________________________________________
Emacs-pretest-bug mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug
