First off, I found what was missing in the "back" routine of your
advanced page. When overriding the destination page, 'return True' to
skip the default behavior (finding page based on widget order):
def on_advanced_back(self, *args):
if self.has_spindle_speed_control():
self.widgets.druid1.set_page(self.widgets.spindle)
elif self.data.axes != 1:
self.widgets.druid1.set_page(self.widgets.zaxis)
else:
self.widgets.druid1.set_page(self.widgets.aaxis)
return True
Now, some nitpicking changes you should make to the advanced page:
. make the top control appear at the top of the window, not part
of the way down.
. make the controls that have no effect when "Include classicladder
plc" is not checked inactive when the checkbox is off.
. Move "number of xxx" to the left, left-justified, slightly indented
with trailing colon and *without a modified color*, so that the
screen looks like this:
[ ] Include classicladder plc
Number of digital out pins: [ 15 ]
Number of digital in pins: [ 15 ]
Number of ... [ 15 ]
. Move "Include modbus master" to be left-justified and indented like
the texts of "Number of ...":
Number of ... [ 15 ]
[ ] Include modbus master
. Something is wrong with the underline of "Include custom _HAL
configuration".
. "Include classicladder PLC" probably doesn't make sense without
"Include custom HAL configuration"; do something about it.
About the "custom hal" checkbox:
An option I'd entertain would be to *remove* the "custom hal" checkbox,
always enabling it. This has no negative effect on users who don't
actually write anything in the custom.hal file. The same goes for
halui (only a slight price in memory is paid), but it doesn't quite for
pyvcp because having an empty one creates an unsightly grey strip at the
right side of the axis window. The fewer unanswerable questions there
are in the wizard, the better.
Please forgive me for being such a nitpicker about the appearance of the
user interface--but I believe very strongly that this kind of thing
makes the software easier to use and more professional-looking.
Jeff
------------------------------------------------------------------------------
_______________________________________________
Emc-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/emc-developers
