Micges,
I reverted your earlier change for several reasons.
Primarily, because it causes the test suite to fail. This does not
indicate that the change is necessarily wrong, but it does change the
sequence of canon calls made; all the tests do is check for an expected
sequence of canon calls.
I commented on this on irc when I first became aware of it, hoping that
you'd see it in the scrollback:
your last change made the interpreter tests fail.
when you change the output of the interpreter, you have to verify
that the changes to the interpreter tests are the expected changes
and if so check in new 'expected' results
'. scripts/emc-environment', then 'runtests' in the top emc2 dir.
Look at failed tests. For each one, 'cd' to it, then 'diff -u
expected result'. If the change in output is expected in view of
your change, then 'cp result expected; cvs commit expected'
You should have been aware of these test failures through "buildbot"
messages on the emc-commit list. If you are not subscribed to this
list, subscribe to it now:
https://lists.sourceforge.net/lists/listinfo/emc-commit
The second reason I am concerned about the change is because, in
general, we don't care that the interpreter state isn't defined after an
abort. This is why we always recommend to put all modal settings at the
top of a part program. Without this change, is there a situation where
programming G64P- at the top of a program doesn't work as expected? If
there is a bug, what is it and how can I see the buggy behavior?
The third reason I am concerned about the change is that it doesn't seem
to do anything about the naive cam tolerance. Without knowing exactly
what it is you're tryting to fix, I obviously can't be sure, but it
seems like you should do somethig with both tolerances at the same time.
Jeff
------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables unlimited
royalty-free distribution of the report engine for externally facing
server and web deployment.
http://p.sf.net/sfu/businessobjects
_______________________________________________
Emc-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/emc-developers
