On Sat, 24 Dec 2011 16:16:49 -0600 Jeff Epler <jep...@unpythonic.net> wrote:
> I applied a form of this patch on v2.5_branch. > > commit 42b8e518ca7c412c5e897c88c0efc12427deb429 > Author: Jeff Epler <jep...@unpythonic.net> > Date: Sat Dec 24 10:25:48 2011 -0600 > > motion: remove useless call to ceil() > > This call was useless, and reportedly causes some unspecified older > compilers to encounter internal compiler errors. Others may warn > about the implicit conversion from int to double (as this makes the > code incompatible with pre-ANSI C compilers, something we all care > deeply about). > > The original change may have intended to be something more like > ceil((double)traj_period_nsec / nsec) > but since all we really care about is that the servo multiplier is > an exact integer, it's preferable to preserve the existing behavior > and just remove the useless function call. > > Thank you for the original report. Ok, thanks for applying it. The "unspecified older compiler" is the Debian Lenny x86_64 gcc, which is derived from gcc-4.3.2. Just for the archive... -- Greetings, Michael. ------------------------------------------------------------------------------ Write once. Port to many. Get the SDK and tools to simplify cross-platform app development. Create new or port existing apps to sell to consumers worldwide. Explore the Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join http://p.sf.net/sfu/intel-appdev _______________________________________________ Emc-developers mailing list Emc-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/emc-developers
