user mentioned the problem on the forum.
One can't select spindle-on when one has a spindle-pwm signal.
Both try to connect a different signal name to motion.spindle-on
relevent code (this is actually master):
if pwm:
x1 = self.spindlepwm1
x2 = self.spindlepwm2
y1 = self.spindlespeed1
y2 = self.spindlespeed2
scale = (y2-y1) / (x2-x1)
offset = x1 - y1 / scale
print >>file
print >>file, "net spindle-cmd <= motion.spindle-speed-out =>
pwmgen.0.value"
>>> print >>file, "net spindle-enable <= motion.spindle-on =>
pwmgen.0.enable"
print >>file, "net spindle-pwm <= pwmgen.0.pwm"
print >>file, "setp pwmgen.0.pwm-freq %s" % self.spindlecarrier
print >>file, "setp pwmgen.0.scale %s" % scale
print >>file, "setp pwmgen.0.offset %s" % offset
print >>file, "setp pwmgen.0.dither-pwm true"
else:
print >>file, "net spindle-cmd <= motion.spindle-speed-out"
if ON in outputs:
>>> print >>file, "net spindle-on <= motion.spindle-on"
What is the best fix considering user with a custom HAL file using the signals?
I was thinking the signal name should be spindle-on for the spindle PWM
then change:
if ON in outputs and not pwm:
for the spindle-on signal.
If that is agreeable should I fix 2.4 to be merged up?
I haven't actually checked 2.4 or 2.5 yet but assume they are the same.
Opinions?
Chris M
------------------------------------------------------------------------------
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here
http://p.sf.net/sfu/sfd2d-msazure
_______________________________________________
Emc-developers mailing list
Emc-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/emc-developers
