I inspected the list of files added in the ub3 branch for potential problems. Unfortunately, I have found some. The most serious categories are: Files with an "All Rights Reserved" copyright notice, files with no copyright or license declaration, and files not "in the preferred form for modification" (minified js files). There are also some minor issues I noticed.
In my view, being aware of these "All Rights Reserved", no-license, and preferred-form problems, we MUST resolve them before merging the branch. I think it would be very fortunate if we can ensure that all code added in this branch was "GPLv2+" but I would personally not let a GPLv2-only file stand in the way of its adoption. = configs/ARM/BeagleBone/BeBoPr-Bridge/BB-LCNC-BEBOPRBR-00A0.dts = configs/ARM/BeagleBone/K9/Device_Tree_Overlays/BB-BLACK-LCNC-K9-00A0.dts = configs/ARM/BeagleBone/K9/Shapeoko/temp/LCNC-BBB-K9S-00A0.dts Do not contain license declaration. Are these generated files or are they all hand-written? = configs/ARM/BeagleBone/BeBoPr-Bridge/dtc.sh and other new sh files Does not contain license declaration. Some appear to be duplicated in multiple directories; use our facility configs/common so that build process copies to each destination. Or put them in scripts/ if sensible. = configs/ARM/pru-examples/stepgen.p This file seems to be duplicated in multiple locations = scripts/gen-rtapi.ini.sh.in.tmpl = scripts/kernel-vers.sh = scripts/pru_debug Does not contain license declaration = scripts/latency-test-atom Why not merged with scripts/latency-test ? = src/emc/usr_intf/emccontroller.cc = src/emc/usr_intf/emccontroller.hh = src/emc/usr_intf/emcweb.cc = src/emc/usr_intf/emcweb/singleton.hh Please get clearance to license as GPLv2+ from Author = src/emc/usr_intf/emcweb/mongoose.c = src/emc/usr_intf/emcweb/mongoose.h DOS line endings. = src/emc/usr_intf/emcweb/mongoose_wrapper.cc = src/emc/usr_intf/emcweb/mongoose_wrapper.hh = src/emc/usr_intf/emcweb/singleton.hh Does not contain license declaration = src/linuxcncconfig.py-tmp.in Does not contain license declaration = src/rtapi/flavor.c = src/rtapi/num2nam.h = src/rtapi/ring.h = src/rtapi/rsyslogd-linuxcnc.conf = src/rtapi/rt-preempt.c = src/rtapi/rt-preempt.h = src/rtapi/rtapi_common.c = src/rtapi/rtapi_compat.c = src/rtapi/rtapi_compat.h = src/rtapi/rtapi_exception.c = src/rtapi/rtapi_kdetect.c = src/rtapi/rtapi_main.c = src/rtapi/rtapi_module.c = src/rtapi/rtapi_msgd.c = src/rtapi/rtapi_shmem.c = src/rtapi/rtapi_support.c = src/rtapi/rtapi_task.c = src/rtapi/rtapi_time.c = src/rtapi/rtai-kernel.h = src/rtapi/rtapi_compat.h = src/rtapi/rtapi_exception.h = src/rtapi/rtapi_export.h = src/rtapi/rtapi_io.h = src/rtapi/rtapi_kdetect.h = src/rtapi/rtapi_mbarrier.h = src/rtapi/rtapi_pci.h = src/rtapi/rtapi_shmkeys.h = src/rtapi/shmdrv/shmdrv.h = src/rtapi/userpci/list.h = src/rtapi/rtapi_global.h = src/rtapi/shmdrv/mutexwatch.c = src/rtapi/shmdrv/shmdrv.c = src/rtapi/shmdrv/shmdrvapi.c = src/rtapi/ulapi_autoload.c = src/rtapi/ulapi_main.c = src/rtapi/xenomai-kernel.c = src/rtapi/xenomai-kernel.h = src/rtapi/xenomai.c = src/rtapi/xenomai.h Does not contain license declaration = src/rtapi/rtapi_pci.c Please get clearance to license as GPLv2+ from Author = src/rtapi/xeno_math/.e_acos.o.d Should not be shipped = src/rtapi/xeno_math/GNUmakefile.am = src/rtapi/xeno_math/GNUmakefile.in = src/rtapi/xeno_math/Makefile = src/rtapi/xeno_math/Makefile.kbuild Which of these files (if any) are used? = src/rtapi/xeno_math/ceilfloor.c = src/rtapi/xeno_math/frexpldexp.c = src/rtapi/xeno_math/logb.c = src/rtapi/xeno_math/rndint.c = src/rtapi/xeno_math/scalb.c = src/rtapi/xeno_math/sign.c = src/rtapi/xeno_math/fpP.h Contains "All rights reserved" copyright declaration = src/rtapi/xeno_math/s_signgam.c Does not contain license declaration = src/rtapi/xeno_math/libm.c Please get clearance to license as GPLv2+ from Author = tests/bitops.0/bitops.c = tests/rtapi.0/rtapi_test.c Does not contain a license declaration = www/js/jquery-1.4.2.min.js = www/js/jquery-ui-1.8.custom.min.js = www/js/jquery.jqGrid.min.js Minified source is not the Preferred Form for Modification = www/js/miniemc2.js Please get clearance to license as GPLv2+ from Author ------------------------------------------------------------------------------ How ServiceNow helps IT people transform IT departments: 1. Consolidate legacy IT systems to a single system of record for IT 2. Standardize and globalize service processes across IT 3. Implement zero-touch automation to replace manual, redundant tasks http://pubads.g.doubleclick.net/gampad/clk?id=51271111&iu=/4140/ostg.clktrk _______________________________________________ Emc-developers mailing list Emc-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/emc-developers
