This is only my opinion, others may see it differently. (You certainly do.)
My opinion is that any time you find yourself saying "This saves the user from having to use a HAL component for some specific setup.", you are on the wrong track. If some particular task MUST have internal knowledge of the motion controller state, then it is a reasonable candidate for inclusion in the motion controller. But if it CAN be done outside of motion using simple (or not- so-simple) arrangements of HAL components, then that is how it SHOULD be done. You can never anticipate every system's requirements. Once you start building support for a VFD into the motion controller, when do you stop? What if a theoretical mathematician decides that he wants the speed command for his VFD in radians per second instead of RPM? Do you add yet another pin to motion? A signed velocity output in one well documented unit of measure can be converted to whatever the user's spindle drive-train requires in HAL. Any additional outputs from motion are redundant. As an aside, I would rather see a new HAL component (or an extension of the abs component) that has both the absolute value output and a pin (or pair of pins) that indicate the sign of the input. Having written that comp, it can be used anywhere that a speed/direction drive is being used, not just on a spindle. John Kasunich On Sun, Sep 29, 2013, at 06:14 PM, Chris Morley wrote: > Here is a patch for adding two pins to motion. > They are spindle velocity with absolute output > one for RPM and one for RPS. > It is common to require an absolute velocity > for such things as a 0-10 volt control. This saves > users having to use the abs component. It also > compliments the spindle fwd and rev pins. > > As usual if I hear a good reason not to push, > I won't otherwise I will push after a bit more testing > > Chris M > > ------------------------------------------------------------------------------ > October Webinars: Code for Performance > Free Intel webinars can help you accelerate application performance. > Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from > the latest Intel processors and coprocessors. See abstracts and register > > http://pubads.g.doubleclick.net/gampad/clk?id=60133471&iu=/4140/ostg.clktrk > _______________________________________________ > Emc-developers mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/emc-developers > Email had 1 attachment: > + spindle_abs_velocity_pins.patch > 5k (application/octet-stream) -- John Kasunich [email protected] ------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60133471&iu=/4140/ostg.clktrk _______________________________________________ Emc-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/emc-developers
