> Date: Fri, 6 Jun 2014 20:54:48 -0500 > From: ch...@timeguy.com > To: emc-developers@lists.sourceforge.net > Subject: Re: [Emc-developers] rapid override pin patch > > On Fri, Jun 06, 2014 at 06:52:03AM +0000, Chris Morley wrote: > > This patch adds a pin to motion that allows rapids to be overridden > > from 0 to 100 percent. > > connecting this pin to halui.feed-override.value makes GUI's feed override > > also control rapids. > > > > This patch does not add an NML command to control rapid override, > > That is beyond my skill and I'm not sure necessary. > > > > I pushed an alternative approach to cradek/rapid-override. Please > have a look? > > Chris >
I built your branch seemed to work for me. I didn't test much. My 2 cents worth: If we add the direct-value switch then one could connect halui.feed-override.value to halui.rapid-override.counts... oh hmm one must convert from float to s32 - maybe we should add a float value-in pin too.... anyways the the feed override would control the rapid override even if you use the GUI controls ( if this is what you want) As your code is, I think you could only connect both .counts pin to something like an encoder, so if you didn't have an encoder (eg were just using the GUI slider) you couldn't connect the two. It seems you have it so it can be masked by a M53 code did I read that right? I don't think this should be done. Having a programmer mask a feed override makes sense as it affects finish, masking a rapid override does not effect finish and sure could be a disaster. I think how and when rapid override works should be up to the integrator, not the G code programmer. Feed hold of course should be honoured. I also see you add an INI parameter for max override limit. Do you think this is necessary? In practice, rapid moves are maximum speed moves. If one wants to limit the max speed then wouldn't we just limit the whole machine? Just one less thing a user needs to configure. I'll study up on the code that adds an NML command - I so needed that for another project I tried, but couldn't quite figure it out. Thanks! Chris M ------------------------------------------------------------------------------ HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions Find What Matters Most in Your Big Data with HPCC Systems Open Source. Fast. Scalable. Simple. Ideal for Dirty Data. Leverages Graph Analysis for Fast Processing & Easy Data Exploration http://www.hpccsystems.com _______________________________________________ Emc-developers mailing list Emc-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/emc-developers