On Mon, Jun 09, 2014 at 06:12:55AM +0000, Chris Morley wrote: > > I built your branch seemed to work for me. I didn't test much. > My 2 cents worth:
Thanks for testing! > If we add the direct-value switch then one could connect > halui.feed-override.value to halui.rapid-override.counts... > oh hmm one must convert from float to s32 - maybe we should add > a float value-in pin too.... > anyways the the feed override would control the rapid override > even if you use the GUI controls ( if this is what you want) > As your code is, I think you could only connect both .counts pin > to something like an encoder, so if you didn't have an encoder > (eg were just using the GUI slider) you couldn't connect the two. I'm really sympathetic to your thoughts about the original problem you were fixing here - that it didn't make sense to override both feeds at the same time. I don't think we need to put a lot of effort into making it easy to restore this functionality, as it never made much sense. So instead of worrying about that, I've added rapid override support to AXIS, and I hope the other GUI folks would add support to the other GUIs. > It seems you have it so it can be masked by a M53 code > did I read that right? I don't think this should be done. > Having a programmer mask a feed override makes sense as it > affects finish, masking a rapid override does not effect finish and sure could > be a disaster. > I think how and when rapid override works should be up to the integrator, > not the G code programmer. > Feed hold of course should be honoured. I think the masking should continue to be honored. I think masking the overrides is VERY rarely used (I know I've never programmed it by hand), but where it is used it is critical. The G76 threading cycle uses this functionality for instance - when it gets to the end of the thread pass, it needs to rapid out. I would not want to break that. If you're proofing a lathe program with rapids turned down, you'd want the little thread exit move to still rapid out, but the rest of the positioning moves to be slowed. That is the functionality you should currently get. > I also see you add an INI parameter for max override limit. > Do you think this is necessary? Nope, you guys are right, and I removed it. > I'll study up on the code that adds an NML command - I so needed that > for another project I tried, but couldn't quite figure it out. Thanks! Welcome! Chris ------------------------------------------------------------------------------ HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions Find What Matters Most in Your Big Data with HPCC Systems Open Source. Fast. Scalable. Simple. Ideal for Dirty Data. Leverages Graph Analysis for Fast Processing & Easy Data Exploration http://p.sf.net/sfu/hpccsystems _______________________________________________ Emc-developers mailing list Emc-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/emc-developers
