Yes, originally I had the calculation of min_velocity incorrect. Here is the commit difference. It only worked for 10% velocity tolerance
- float min_velocity = requested_vel -(requested_vel*(1/velocity_tol)); + float min_velocity = requested_vel -(requested_vel*(velocity_tol*0.01)); On 7/7/2014 11:40 PM, Marius Alksnys wrote: > You wrote the line earlier as: > min_velocity = requested_vel - ( requested_vel > -(requested_vel*(velocity_tol/100))); > and now you are writing it as: > min_velocity = requested_vel - (requested_vel * (velocity_tol * 0.01)); > That's why I corrected and commented it. > > You can change it to equal form: > min_velocity = requested_vel * (1 - velocity_tol * 0.01); > > On 2014.07.07 15:09, John Thornton wrote: >> To avoid the divide by zero error I changed the original line in thc and >> thcud to: >> >> float min_velocity = requested_vel - (requested_vel * (velocity_tol * >> 0.01)); >> >> requested_vel = 100 >> velocity_tol = 10 >> min_velocity = 90 >> >> 90 = 100 - (100 * (10 * 0.01)) >> >> I'm not that great with math... when I did some examples of your >> simplified line it didn't work out for me. >> min_velocity = requested_vel * velocity_tol / 100 >> ? = 100 * 10 / 100 >> ? = 1000 / 100 >> 10 = 10 >> >> As for the suggestion to use requested_vel as part of the calculation of >> correction_vel I don't understand why that is good. IMHO the >> correction_vel should be as fast as the axis can correct without >> overshoot no matter what speed your cutting at. >> >> Any suggestions on making the description easier to understand are welcome. >> >> JT >> > > ------------------------------------------------------------------------------ > Open source business process management suite built on Java and Eclipse > Turn processes into business applications with Bonita BPM Community Edition > Quickly connect people, data, and systems into organized workflows > Winner of BOSSIE, CODIE, OW2 and Gartner awards > http://p.sf.net/sfu/Bonitasoft > _______________________________________________ > Emc-developers mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/emc-developers ------------------------------------------------------------------------------ Open source business process management suite built on Java and Eclipse Turn processes into business applications with Bonita BPM Community Edition Quickly connect people, data, and systems into organized workflows Winner of BOSSIE, CODIE, OW2 and Gartner awards http://p.sf.net/sfu/Bonitasoft _______________________________________________ Emc-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/emc-developers
