On 02/12/2015 05:43 AM, Bence Kovács wrote: > Dear Sebastian, > > Much later than expected, but we could finaly finish gm6-PCI driver > USPACE support, tests, and we made also some fixes (all togeather 3 > commits): > https://github.com/geris2/linuxcnc-mirror/tree/gm-fix > Could you check in to git?
Hi Bence, Gergő! I looked at your commits and the code looks good. I'd love to get these fixes into linuxcnc. A couple of issues: All three of these commits currently say "Author: cnc <cnc@cnc-desktop>", but linuxcnc dev policy requires[0] that the Author be a real person with a real email address. 0: http://linuxcnc.org/docs/html/code/Contributing-to-LinuxCNC.html#_git_configuration All commits also need to have a Signed-off-By: field[1], which certifies that the Author has the legal right to publish the source code under the specified license. (This is a new requirement that we added since last time you sent me a pull request.) 1: http://linuxcnc.org/docs/html/code/Contributing-to-LinuxCNC.html#_signed_off_by_policy Ok, those mechanical issues aside, i have another question. The first commit (that fixes the rs485 zero-voltage thing) and the last commit (that changes the license) should go into 2.6, right? And the middle commit (the one that adds uspace support) should go into 2.7 obviously. Thanks for your continued support of linuxcnc :-) -- Sebastian Kuzminsky ------------------------------------------------------------------------------ Dive into the World of Parallel Programming. The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ _______________________________________________ Emc-developers mailing list Emc-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/emc-developers
