Please keep replies on the list. Whole message quoted so that the context is not lost.

On Tue, Jun 27, 2017 at 09:39:00AM +1000, Phillip Carter wrote:
On 26/06/17 22:34, Jeff Epler wrote:

   On Mon, Jun 26, 2017 at 02:58:42PM +1000, Phillip Carter wrote:

       Is the documentation correct for the LinuxCNC Python Module in
       regards to kinematics_type?

       In the documentation for the LinuxCNC Python Interface there is
       reference to:
       kinematics_type
       (returns integer) - identity=1, serial=2, parallel=3, custom=4 .


   Yeah I agree that is not what the module does.  Use the pseudo-enumerated
   values you see in emcmodule.cc:

       ENUM(KINEMATICS_IDENTITY);
       ENUM(KINEMATICS_FORWARD_ONLY);
       ENUM(KINEMATICS_INVERSE_ONLY);
       ENUM(KINEMATICS_BOTH);

That being the case:
In commit [1]681cf92 I created a variable (trivkinstype) that I now think is
unnecessary.
Should I submit a patch that removes this variable?

Yes, I suspect it is more correct to get this value from the stat buffer instead of from an inifile item. For one thing, the code that is parsing the [KINS]KINEMATICS value will only work when the kinematics is trivkins, not when it's something else like genserkins, right?

Jeff


   doc patches welcome.


I will look into this.


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Emc-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/emc-developers

Reply via email to