Hi Andy,
this is really a great addition - I already often thought that a modbus
driver for the mesa cards is somehow missing. Thanks for that!
The docs are quite comprehensive, so no real need to add something.
However, some annotations:
- The created HAL pins are inputs for some modbus commands and outputs
for some others. Maybe that could be mentioned. At least in the comments
in the sample. I mean it's quite clear when looking at the table for
example, but..
- The three samples could be listed in a "Samples" section with links to
the corresponding files. (Could maybe also move to a samples directory)
- And I guess you will add a link to the index.tmpl and integrate it in
the docs chain.
Unfortunately I am currently not there where my hardware is, so I cannot
test it with my modbus device.
Hans
Am 19.04.23 um 03:00 schrieb andy pugh:
I have just pushed a feature branch (andypugh/mesa_modbus) to the LinuxCNC
github.
It uses the Mesa FPGA UARTs (specifically pktUART) to offer real-time
modbus connection directly to a Mesa card.
Docs are here:
https://github.com/LinuxCNC/linuxcnc/blob/andypugh/mesa_modbus/docs/src/drivers/mesa_modbus.adoc
Please let me know of anything that you feel you need to know that the docs
omit.
At the moment you will find mesa_modbus.c and the modcompile script in
linuxcnc-dev/src/hal/drivers/mesa_hostmot2/modbus along with some sample
configuration files.
Pin assignments and names are compiled-in rather than being determined at
load time.
_______________________________________________
Emc-developers mailing list
Emc-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/emc-developers
