Rene, Just to be clear on the record: I don't think anyone objects to the review process itself; I agree it's valuable, especially for the big changes that touch many things. But I think the question worth asking is a slightly different one: not "do we want reviews," but "do we want reviews enforced for everything, including trivial stuff?" I ask because most of my direct pushes have been minor doc fixes and such, where a PR is mostly clicking through ceremony. And let's be honest, pushes to master have broken the tree for a few hours before; that happens, and we've always fixed it. I'm not sure that alone warrants locking down the whole workflow. None of this is meant as a dig at turning protection on; I understand why you did it given this week's events, and reverting the mess was probably no fun. I'd just have preferred the question to go to the list before the switch flipped, since it changes how everyone works day to day. Being the newest voice here I'm happy to go with whatever the group decides either way, but figured it was worth saying out loud.
Luca On September 17, 2026 6:44:54 PM GMT+08:00, Rene Hopf via Emc-developers <[email protected]> wrote: > > >On 9/17/26 03:50, Chris Morley wrote: >> When did we agree on that? > >It was already the case when I joined the project, and people have been doing >this for years, except for minor bugfixes. >It is also mentioned in the documentation. Does anyone object the idea of a >review process? >especially for large changes that touch many things, this is important. > >> If we did why did we not set protection on then? > >because nobody turned it on. > >> ________________________________ >> From: Rene Hopf via Emc-developers <[email protected]> >> Sent: September 16, 2026 11:56 PM >> To: EMC developers <[email protected]> >> Cc: Rene Hopf <[email protected]> >> Subject: [Emc-developers] branch protection turned on >> >> Due to the recent events on github, I have turned on branch protection >> on github. This means that everything that goes into master must go >> through a PR, like we all have agreed to for a long time. >> This gives other developers a chance to review and talk about your >> changes. Now it is enforced by github. The changes have been reverted. >> Same applies for 2.x branches. >> >> René >> >> >> _______________________________________________ >> Emc-developers mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/emc-developers >> >> _______________________________________________ >> Emc-developers mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/emc-developers > > > >_______________________________________________ >Emc-developers mailing list >[email protected] >https://lists.sourceforge.net/lists/listinfo/emc-developers _______________________________________________ Emc-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/emc-developers
