Do you push directly to master? Or via a PR? It's perfectly possible
to create a PR and then merge it yourself for trivial / uncontroversial
changes.> Pushing directly to master It's not my usual or preferred workflow,
but
I did do it a couple of times, on locally tested uncontroversial changes
I didn't want to wait the CI for. PR and self merge works well for
me, I don't really have a dog in this fight... But I keep track of the
commits, I think (but might be wrong) every active dev other than Bertho
has pushed to master on a few occasions, Chris being the most frequent
one, so we should wait for his take...
As I mentioned before in the thread that started the discussion.
Pushing to master directly should only be done when there is an imminent
problem that needs fixing right away. That is a very rare occasion.
Everything else should be done using PRs and standard review.
As Andy remarked, small stuff can be merged by one self. Having a PR
trail, even for the small things, is just good practice so everybody can
see the same things unfold.
I don't care about branch protection as such. It is a corset to remove
the blood flow to the impulsive parts of the brain. Usually I would
prefer to kill my brain in other more pleasant ways. Technical measures
never really fix bad habits and can cause collateral damage if not
applied with great care. In the end, it is a balancing act.
--
Greetings Bertho
(disclaimers are disclaimed)
_______________________________________________
Emc-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/emc-developers
