Yoni Rabkin writes:
> Grant Shoshin Shangreaux <[email protected]> writes: > >> Yoni Rabkin writes: >> >>> Grant Shoshin Shangreaux <[email protected]> writes: >>> >>>> +(defun emms-tag-editor--track-editable-p (track) >>>> + "Return t if TRACK is not a file, or has a tagfile function defined." >>>> + (or (not (emms-track-file-p track)) >>>> + (emms-tag-editor--tagfile-function track))) >>> >>> Why check if it is a file? Not all files are editable (e.g. .pls, .m3u). >> >> Oh, good point. This was to allow editing of URL tracks for example. I >> just assumed if the track isn't a file we can allow adding metadata to >> the cache-db if desired. We're not trying to write to any file so just >> allow it as editable. If it /is/ a file then we check for a tagfile >> function. Considering we won't have one defined for .pls or .m3u this >> should catch those, correct? > > It is a roundabout way of addressing it, but perfectly valid. It can > stay that way. Now that I think of it, I totally agree. Perhaps it would be better to enumerate which types of tracks allow editing of metadata? I admit, I'm not deeply familiar with all of the track types. I do see benefit in adding metadata to URL tracks, even if it is only in the cache-db. Let me know if there's any further thoughts on this. I am happy to improve the code in another pass so it is a bit more clear.
