Grant Shoshin Shangreaux <[email protected]> writes: > Yoni Rabkin writes: > >> Grant Shoshin Shangreaux <[email protected]> writes: >> >>> Yoni Rabkin writes: >>> >>>> Grant Shoshin Shangreaux <[email protected]> writes: >>>> >>>>> +(defun emms-tag-editor--track-editable-p (track) >>>>> + "Return t if TRACK is not a file, or has a tagfile function defined." >>>>> + (or (not (emms-track-file-p track)) >>>>> + (emms-tag-editor--tagfile-function track))) >>>> >>>> Why check if it is a file? Not all files are editable (e.g. .pls, .m3u). >>> >>> Oh, good point. This was to allow editing of URL tracks for example. I >>> just assumed if the track isn't a file we can allow adding metadata to >>> the cache-db if desired. We're not trying to write to any file so just >>> allow it as editable. If it /is/ a file then we check for a tagfile >>> function. Considering we won't have one defined for .pls or .m3u this >>> should catch those, correct? >> >> It is a roundabout way of addressing it, but perfectly valid. It can >> stay that way. > > Now that I think of it, I totally agree. Perhaps it would be better to > enumerate which types of tracks allow editing of metadata?
Another edge case we may as well look at are non-local files. For instance, it may be a good thing to figure out if this is a file from an mpd queue, and therefore not a file that any tag editor local to the machine can edit. -- "Cut your own wood and it will warm you twice"
