Yes I'll try to find out what's missing there. -Floh.
Am Freitag, 11. Juli 2014 02:45:38 UTC+2 schrieb Alon Zakai: > > Would be good to track down that closure issue, must be something we need > to tell it about to not minify. > > - Alon > > > > On Wed, Jul 9, 2014 at 2:53 PM, Floh <[email protected] <javascript:>> > wrote: > >> When using the desktop GL wrapper and using the closure pass in the >> linker stage I'm getting a strange JS exception which could be a function >> removed by closure. It works if closure is not used. >> >> The error on the JS console is (I can try to dig deeper, but for now I'll >> just try to workaround that issue): >> >> "exception thrown: TypeError: Qb.Mg is not a >> function,W<._glVertexAttribDivisor@ >> http://0.0.0.0:8000/Instancing.js:215:256 >> Xj@http://0.0.0.0:8000/Instancing.js:158:2285 >> Pj@http://0.0.0.0:8000/Instancing.js:162:124588 >> Oj@http://0.0.0.0:8000/Instancing.js:162:123423 >> rg@http://0.0.0.0:8000/Instancing.js:162:48225 >> mf@http://0.0.0.0:8000/Instancing.js:162:29968 >> jf@http://0.0.0.0:8000/Instancing.js:162:29413 >> ke@http://0.0.0.0:8000/Instancing.js:162:2100 >> ln@http://0.0.0.0:8000/Instancing.js:158:70474 >> fn@http://0.0.0.0:8000/Instancing.js:158:68596 >> _z@http://0.0.0.0:8000/Instancing.js:178:54528 >> w.Ha@http://0.0.0.0:8000/Instancing.js:11:296 >> W<._emscripten_set_main_loop/jd@http://0.0.0.0:8000/Instancing.js:218:101 >> " >> >> Am Mittwoch, 9. Juli 2014 22:55:47 UTC+2 schrieb Floh: >> >>> Hi, >>> >>> just noticed this and wrote a ticket: https://github.com/ >>> kripken/emscripten/issues/2510 >>> >>> Since most (all?) browser have now implemented this extension it would >>> be nice to have this also in the GLES2 wrapper (it seems to be implemented >>> in the desktop GL wrapper). >>> >>> Results in PNaCl looks quite promising (WebGL should be similar): I can >>> go up to >65k instanced draws instead of ~6k non-instanced draws before >>> dropping below 60fps. >>> >>> Even then it looks like the dynamic vertex buffer update for the >>> instance data is the problem (I'm using buffer orphaning, but the >>> transferred data becomes quite big, 16 bytes per instance, so at 65k draws >>> this would be >1MByte dynamic vertex data transferred per frame), so the >>> numbers would very likely be higher if the instance data is static. >>> >>> Cheers! >>> -Floh. >>> >> -- >> You received this message because you are subscribed to the Google Groups >> "emscripten-discuss" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected] <javascript:>. >> For more options, visit https://groups.google.com/d/optout. >> > > -- You received this message because you are subscribed to the Google Groups "emscripten-discuss" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
