I took the 1 line patch and put it onto my 1.38.36 and it seems to fix it.
Thanks for the quick fix. John On Wednesday, 26 June 2019 03:27:44 UTC+1, Alon Zakai wrote: > > This should now be fixed, the emsdk will set the path to the asm.js > optimizer, as of > > https://github.com/emscripten-core/emsdk/pull/289 > > which landed on emsdk master earlier today. Please test and report any > issues. > > - Alon > > > On Tue, Jun 25, 2019 at 7:37 AM 'John Harvey' via emscripten-discuss < > [email protected] <javascript:>> wrote: > >> We build both wasm & asmjs because we have customers using IE still that >> we cant get away from. So fall back to asm.js when webassembly not >> available. >> >> Looks like i can set EMSCRIPTEN_NATIVE_OPTIMISER=path to optimizer as an >> environment variable to work around this for now. >> >> Thanks >> >> John >> >> On Tuesday, 25 June 2019 15:23:12 UTC+1, Alon Zakai wrote: >>> >>> Sorry for this - this is because of our switching build infrastructures. >>> I didn't realize the old one special-cased the native optimizer that way. >>> >>> We can support this by bundling the build of the optimizer, we are just >>> in the process of supporting such bundling here: >>> https://github.com/emscripten-core/emsdk/pull/282 I'll add a note there >>> about this, and hopefully we can do that very soon. >>> >>> Btw, that optimizer only matters for asm.js - are you still using asm.js >>> and not wasm? I'm curious why (also, using wasm would work around this >>> problem for you). >>> >>> - Alon >>> >>> >>> On Tue, Jun 25, 2019 at 4:49 AM 'John Harvey' via emscripten-discuss < >>> [email protected]> wrote: >>> >>>> When we were using 1.38.26 and run emsdk activate the .emscripten file >>>> was written with >>>> >>>> >>>> import os >>>> LLVM_ROOT = >>>> '/opt/compilers/emscripten-1.38.26-linux/clang/e1.38.26_64bit' >>>> EMSCRIPTEN_NATIVE_OPTIMIZER = >>>> '/opt/compilers/emscripten-1.38.26-linux/clang/e1.38.26_64bit/optimizer' >>>> BINARYEN_ROOT = >>>> '/opt/compilers/emscripten-1.38.26-linux/clang/e1.38.26_64bit/binaryen' >>>> NODE_JS = >>>> '/opt/compilers/emscripten-1.38.26-linux/node/8.9.1_64bit/bin/node' >>>> EMSCRIPTEN_ROOT = >>>> '/opt/compilers/emscripten-1.38.26-linux/emscripten/1.38.26' >>>> SPIDERMONKEY_ENGINE = '' >>>> V8_ENGINE = '' >>>> TEMP_DIR = '/tmp' >>>> COMPILER_ENGINE = NODE_JS >>>> JS_ENGINES = [NODE_JS] >>>> >>>> Now in 1.38.36 we get :- >>>> >>>> >>>> import os >>>> LLVM_ROOT = >>>> '/opt/compilers/emscripten-1.38.36-linux/fastcomp/fastcomp/bin' >>>> BINARYEN_ROOT = '/opt/compilers/emscripten-1.38.36-linux/fastcomp' >>>> NODE_JS = >>>> '/opt/compilers/emscripten-1.38.36-linux/node/8.9.1_64bit/bin/node' >>>> SPIDERMONKEY_ENGINE = '' >>>> V8_ENGINE = '' >>>> TEMP_DIR = '/tmp' >>>> COMPILER_ENGINE = NODE_JS >>>> JS_ENGINES = [NODE_JS] >>>> >>>> >>>> This doesn't reference >>>> >>>> EMSCRIPTEN_NATIVE_OPTIMIZER = >>>> '/opt/compilers/emscripten-1.38.26-linux/clang/e1.38.26_64bit/optimizer' >>>> even though >>>> /opt/compilers/emscripten-1.38.36-linux/fastcomp/fastcomp/bin/optimizer >>>> exists and then when we link targeting asm_js it tries to build >>>> optimizer.2.exe We have been trying to deliver an environment to our >>>> developers where they shouldn't need to build any tools which has worked >>>> in >>>> the past but now we need a native developer toolchain in order to do the >>>> cross compilation. Was this a deliberate change and is there a way to >>>> provide a complete pre-built environment still? Thanks John >>>> >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "emscripten-discuss" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to [email protected]. >>>> To view this discussion on the web visit >>>> https://groups.google.com/d/msgid/emscripten-discuss/eb678a80-7b46-4876-9539-e09c574bad96%40googlegroups.com >>>> >>>> <https://groups.google.com/d/msgid/emscripten-discuss/eb678a80-7b46-4876-9539-e09c574bad96%40googlegroups.com?utm_medium=email&utm_source=footer> >>>> . >>>> For more options, visit https://groups.google.com/d/optout. >>>> >>> -- >> You received this message because you are subscribed to the Google Groups >> "emscripten-discuss" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected] <javascript:>. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/emscripten-discuss/fb455282-99ef-498f-8d6a-c3ef4449ecd3%40googlegroups.com >> >> <https://groups.google.com/d/msgid/emscripten-discuss/fb455282-99ef-498f-8d6a-c3ef4449ecd3%40googlegroups.com?utm_medium=email&utm_source=footer> >> . >> For more options, visit https://groups.google.com/d/optout. >> > -- You received this message because you are subscribed to the Google Groups "emscripten-discuss" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/emscripten-discuss/c4d84d20-60a5-4a01-9bab-cd827501b0e7%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
