On 19/02/2013 12:06, Laszlo Hornyak wrote:
Hi,
I agree with that.
for the - messages this in my opinion would be both more clear and friendly:
-1: In my opinion it needs work.
how about
"-1: Please review my comments"
-2: I disagree.
"-2: Please reconsider"
----- Original Message -----
From: "Ofer Schreiber" <[email protected]>
To: [email protected]
Sent: Tuesday, February 19, 2013 10:51:15 AM
Subject: [Engine-devel] Changing Gerrit -1 message
I feel that the current "-1 I would prefer that you didn't submit
this" message in Gerrit is pretty rude, as usually those -1 reviews
are just small fix-ups in the code itself.
Any thoughts about a more suitable "-1" message?
I thought about "-1 Please fix your code" or something similar.
Thanks,
Ofer Schreiber
_______________________________________________
Engine-devel mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-devel
_______________________________________________
Engine-devel mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-devel
_______________________________________________
Engine-devel mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-devel
