----- Original Message ----- > From: "Dave Neary" <[email protected]> > To: [email protected] > Sent: Thursday, February 21, 2013 11:21:53 PM > Subject: Re: [Engine-devel] Changing Gerrit -1 message > > Hi, > > On 02/20/2013 10:32 AM, Itamar Heim wrote: > > On 19/02/2013 12:06, Laszlo Hornyak wrote: > >> Hi, > >> > >> I agree with that. > >> > >> for the - messages this in my opinion would be both more clear and > >> friendly: > >> -1: In my opinion it needs work. > > > > > > how about > > "-1: Please review my comments"
+1 > > Sounds great. > > >> -2: I disagree. I prefer -2 : Do not submit! IMHO: -1 should be used whenever the code is OK but can be done better or has a missing part (tests for example) -2 should be used when the code does not work, has a serious bug (possible NPE for example) , break the build > > > > "-2: Please reconsider" > > I am trying to think under which circumstances people give a -2. > Maybe > something like "We have discussed this feature, and I disagree that > it > is good for the project." Basically, I don't think that a developer > should ever see a -2, unless they specifically disagree with the > maintainer, and insist that they are right, to the point of > repeatedly > submitting patches. > > Cheers, > Dave. > > -- > Dave Neary - Community Action and Impact > Open Source and Standards, Red Hat - http://community.redhat.com > Ph: +33 9 50 71 55 62 / Cell: +33 6 77 01 92 13 > _______________________________________________ > Engine-devel mailing list > [email protected] > http://lists.ovirt.org/mailman/listinfo/engine-devel > _______________________________________________ Engine-devel mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-devel
