----- Original Message ----- > From: "Juan Hernandez" <jhern...@redhat.com> > To: "Einav Cohen" <eco...@redhat.com>, "Gilad Chaplik" <gchap...@redhat.com>, > "Martin Perina" <mper...@redhat.com> > Cc: "engine-devel" <engine-devel@ovirt.org> > Sent: Monday, March 24, 2014 5:33:49 PM > Subject: Re: [Engine-devel] REST API - where did bookmarks go? > > On 03/24/2014 05:17 PM, Einav Cohen wrote: > >> ----- Original Message ----- > >> From: "Gilad Chaplik" <gchap...@redhat.com> > >> Sent: Monday, March 24, 2014 11:58:01 AM > >> > >> So iiuc, we are going to develop a known obsolete feature :-) ? > >> Can we break it in 4.0? > > > > well, since they were never exposed, we can also decide that we are > > not implementing them at all, but this means that we are losing the > > server-side bookmarks once we move the GUI to work with the REST-API. > > question is if everyone are OK with that... > > > > to be on the safe side and to not lose any functionality/data, I > > suggest to add them to the REST API, and for 4.0 - discuss whether > > they should be removed (and possibly replaced with client-side > > bookmarks in the GUI) > > > > Actually adding support for bookmarks has been targeted for 4.0, and > work is about to start (if not started yet). > > Martin, please, don't start working on this till it is decided if we > will have or not the bookmarks in 4.0.
Ok, I will wait until decision is made. > > >> > >> Thanks, > >> Gilad. > >> > >> > >> ----- Original Message ----- > >>> From: "Einav Cohen" <eco...@redhat.com> > >>> To: "Gilad Chaplik" <gchap...@redhat.com> > >>> Cc: "Juan Hernandez" <jhern...@redhat.com>, "engine-devel" > >>> <engine-devel@ovirt.org> > >>> Sent: Monday, March 24, 2014 5:55:20 PM > >>> Subject: Re: [Engine-devel] REST API - where did bookmarks go? > >>> > >>>> ----- Original Message ----- > >>>> From: "Gilad Chaplik" <gchap...@redhat.com> > >>>> Sent: Monday, March 24, 2014 11:46:04 AM > >>>> > >>>> Hi Einav, > >>>> > >>>> I agree with every word. also thought about it, that's why I wrote a > >>>> possible > >>>> solution. > >>>> Not sure we need to design the RESTful API according to UI's needs (add > >>>> features in this case). > >>> > >>> the REST API should not be designed according to UI's needs - but the > >>> REST > >>> API > >>> should allow to retrieve all engine-managed business entities. Bookmarks > >>> is > >>> one > >>> of them. > >>> There is a chance that creating Bookmarks as an engine-managed > >>> business-entity > >>> in the first place was a bad design decision, but they are there now, as > >>> managed > >>> business-entities, and as such - should be exposed via the REST API. > >>> > >>>> > >>>> > >>>> > >>>> Thanks, > >>>> Gilad. > >>>> > >>>> > >>>> ----- Original Message ----- > >>>>> From: "Einav Cohen" <eco...@redhat.com> > >>>>> To: "Gilad Chaplik" <gchap...@redhat.com> > >>>>> Cc: "Vojtech Szocs" <vsz...@redhat.com>, "Juan Hernandez" > >>>>> <jhern...@redhat.com>, "engine-devel" > >>>>> <engine-devel@ovirt.org> > >>>>> Sent: Monday, March 24, 2014 5:38:33 PM > >>>>> Subject: Re: [Engine-devel] REST API - where did bookmarks go? > >>>>> > >>>>> Hi Gilad, "client-side Bookmarks" is a great suggestion, however it > >>>>> is a (non-related) RFE, which may be implemented instead of, or in > >>>>> addition to, the already-existing server-side Bookmarks. > >>>>> > >>>>> [keep in mind that server-side bookmarks allow you to add bookmarks > >>>>> that may be used by other users; it is also a feature that exists > >>>>> for a long time in oVirt, so need to think a little bit before > >>>>> removing it] > >>>>> > >>>>> As long as we have server-side Bookmarks (i.e. as long as Bookmark > >>>>> is an engine-managed business entity), they need to be exposed via > >>>>> the REST API. > >>>>> > >>>>> ---- > >>>>> Thanks, > >>>>> Einav > >>>>> > >>>>> ----- Original Message ----- > >>>>>> From: "Gilad Chaplik" <gchap...@redhat.com> > >>>>>> To: "Vojtech Szocs" <vsz...@redhat.com> > >>>>>> Cc: "Juan Hernandez" <jhern...@redhat.com>, "engine-devel" > >>>>>> <engine-devel@ovirt.org> > >>>>>> Sent: Monday, March 24, 2014 11:28:02 AM > >>>>>> Subject: Re: [Engine-devel] REST API - where did bookmarks go? > >>>>>> > >>>>>> Hi Guys, > >>>>>> > >>>>>> Why we need bookmarks in API? a single liner that points out to > >>>>>> another > >>>>>> single liner? > >>>>>> I know that we need it for 'UI over REST' migration, but... > >>>>>> IMHO bookmarks should be saved in client side, maybe inject the > >>>>>> search > >>>>>> string > >>>>>> in the url, and get 'real' bookmarks/favorites... I don't know :-) > >>>>>> > >>>>>> Thanks, > >>>>>> Gilad. > >>>>>> > >>>>>> ----- Original Message ----- > >>>>>>> From: "Vojtech Szocs" <vsz...@redhat.com> > >>>>>>> To: "Juan Hernandez" <jhern...@redhat.com> > >>>>>>> Cc: "engine-devel" <engine-devel@ovirt.org> > >>>>>>> Sent: Wednesday, March 12, 2014 1:27:19 PM > >>>>>>> Subject: Re: [Engine-devel] REST API - where did bookmarks go? > >>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> ----- Original Message ----- > >>>>>>>> From: "Juan Hernandez" <jhern...@redhat.com> > >>>>>>>> To: "Vojtech Szocs" <vsz...@redhat.com>, "engine-devel" > >>>>>>>> <engine-devel@ovirt.org> > >>>>>>>> Cc: "Einav Cohen" <eco...@redhat.com> > >>>>>>>> Sent: Tuesday, March 11, 2014 7:22:35 PM > >>>>>>>> Subject: Re: REST API - where did bookmarks go? > >>>>>>>> > >>>>>>>> On 03/11/2014 07:15 PM, Vojtech Szocs wrote: > >>>>>>>>> Hi guys, > >>>>>>>>> > >>>>>>>>> as part of prototyping new JavaScript binding for oVirt REST > >>>>>>>>> API, > >>>>>>>>> we chose a couple of business entities (resources) to > >>>>>>>>> experiment > >>>>>>>>> with. > >>>>>>>>> > >>>>>>>>> I just realized that requesting /ovirt-engine/api doesn't > >>>>>>>>> return > >>>>>>>>> any information about bookmarks. Where did bookmarks go? Is it > >>>>>>>>> possible to manage bookmarks through REST API? > >>>>>>>>> > >>>>>>>>> Note: WebAdmin currently gets bookmarks through GWT RPC by > >>>>>>>>> calling > >>>>>>>>> GetAllBookmarksQuery. Bookmark seems like proper backend > >>>>>>>>> business > >>>>>>>>> entity (with DAO and everything) so it should be exposed also > >>>>>>>>> via > >>>>>>>>> REST API.. or am I missing something? > >>>>>>>>> > >>>>>>>>> Thanks, > >>>>>>>>> Vojtech > >>>>>>>>> > >>>>>>>> > >>>>>>>> The didn't go anywhere, just never existed in the API. Please > >>>>>>>> open > >>>>>>>> a > >>>>>>>> RFE > >>>>>>>> to add them. > >>>>>>> > >>>>>>> Thanks, Juan. The RFE is here: > >>>>>>> > >>>>>>> https://bugzilla.redhat.com/1075556 > >>>>>>> > > > -- > Dirección Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3, planta > 3ºD, 28016 Madrid, Spain > Inscrita en el Reg. Mercantil de Madrid – C.I.F. B82657941 - Red Hat S.L. > _______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
