----- Original Message ----- > From: "Itamar Heim" <ih...@redhat.com> > To: "Vojtech Szocs" <vsz...@redhat.com>, "Gilad Chaplik" <gchap...@redhat.com> > Cc: "Juan Hernandez" <jhern...@redhat.com>, "engine-devel" > <engine-devel@ovirt.org> > Sent: Tuesday, March 25, 2014 12:17:48 AM > Subject: Re: [Engine-devel] REST API - where did bookmarks go? > > On 03/24/2014 12:40 PM, Vojtech Szocs wrote: > > > > > > ----- Original Message ----- > >> From: "Gilad Chaplik" <gchap...@redhat.com> > >> To: "Einav Cohen" <eco...@redhat.com> > >> Cc: "Vojtech Szocs" <vsz...@redhat.com>, "Juan Hernandez" > >> <jhern...@redhat.com>, "engine-devel" > >> <engine-devel@ovirt.org> > >> Sent: Monday, March 24, 2014 4:46:04 PM > >> Subject: Re: [Engine-devel] REST API - where did bookmarks go? > >> > >> Hi Einav, > >> > >> I agree with every word. also thought about it, that's why I wrote a > >> possible > >> solution. > >> Not sure we need to design the RESTful API according to UI's needs (add > >> features in this case). > > > > I think that API should accomodate general/common needs of its clients. > > After all, the usefulness of API can be measured by its usability from > > client's perspective. > > > > At one extreme, API adapts to each specific client, which in turn bloats > > the API. At another extreme, API lives in isolated bubble and doesn't care > > for its clients. Each of these extremes is dangerous :) > > I find shared bookmarks useful. > i do actually think they should have had permissions: > - who can see my bookmarks > - who can share their bookmarks with others
I think that nowadays bookmarks are a client side feature only. You can add bookmarks in your browser, and it will exist everywhere (mobile/smartphone/etc) - I use it on a daily basis on 4 different devices. so you are getting these features for free. In 'UI over REST' migration process I suggest to leave bookmarks to last, and reassess then. > > > > >> > >> > >> > >> Thanks, > >> Gilad. > >> > >> > >> ----- Original Message ----- > >>> From: "Einav Cohen" <eco...@redhat.com> > >>> To: "Gilad Chaplik" <gchap...@redhat.com> > >>> Cc: "Vojtech Szocs" <vsz...@redhat.com>, "Juan Hernandez" > >>> <jhern...@redhat.com>, "engine-devel" > >>> <engine-devel@ovirt.org> > >>> Sent: Monday, March 24, 2014 5:38:33 PM > >>> Subject: Re: [Engine-devel] REST API - where did bookmarks go? > >>> > >>> Hi Gilad, "client-side Bookmarks" is a great suggestion, however it > >>> is a (non-related) RFE, which may be implemented instead of, or in > >>> addition to, the already-existing server-side Bookmarks. > >>> > >>> [keep in mind that server-side bookmarks allow you to add bookmarks > >>> that may be used by other users; it is also a feature that exists > >>> for a long time in oVirt, so need to think a little bit before > >>> removing it] > >>> > >>> As long as we have server-side Bookmarks (i.e. as long as Bookmark > >>> is an engine-managed business entity), they need to be exposed via > >>> the REST API. > >>> > >>> ---- > >>> Thanks, > >>> Einav > >>> > >>> ----- Original Message ----- > >>>> From: "Gilad Chaplik" <gchap...@redhat.com> > >>>> To: "Vojtech Szocs" <vsz...@redhat.com> > >>>> Cc: "Juan Hernandez" <jhern...@redhat.com>, "engine-devel" > >>>> <engine-devel@ovirt.org> > >>>> Sent: Monday, March 24, 2014 11:28:02 AM > >>>> Subject: Re: [Engine-devel] REST API - where did bookmarks go? > >>>> > >>>> Hi Guys, > >>>> > >>>> Why we need bookmarks in API? a single liner that points out to another > >>>> single liner? > >>>> I know that we need it for 'UI over REST' migration, but... > >>>> IMHO bookmarks should be saved in client side, maybe inject the search > >>>> string > >>>> in the url, and get 'real' bookmarks/favorites... I don't know :-) > >>>> > >>>> Thanks, > >>>> Gilad. > >>>> > >>>> ----- Original Message ----- > >>>>> From: "Vojtech Szocs" <vsz...@redhat.com> > >>>>> To: "Juan Hernandez" <jhern...@redhat.com> > >>>>> Cc: "engine-devel" <engine-devel@ovirt.org> > >>>>> Sent: Wednesday, March 12, 2014 1:27:19 PM > >>>>> Subject: Re: [Engine-devel] REST API - where did bookmarks go? > >>>>> > >>>>> > >>>>> > >>>>> ----- Original Message ----- > >>>>>> From: "Juan Hernandez" <jhern...@redhat.com> > >>>>>> To: "Vojtech Szocs" <vsz...@redhat.com>, "engine-devel" > >>>>>> <engine-devel@ovirt.org> > >>>>>> Cc: "Einav Cohen" <eco...@redhat.com> > >>>>>> Sent: Tuesday, March 11, 2014 7:22:35 PM > >>>>>> Subject: Re: REST API - where did bookmarks go? > >>>>>> > >>>>>> On 03/11/2014 07:15 PM, Vojtech Szocs wrote: > >>>>>>> Hi guys, > >>>>>>> > >>>>>>> as part of prototyping new JavaScript binding for oVirt REST API, > >>>>>>> we chose a couple of business entities (resources) to experiment > >>>>>>> with. > >>>>>>> > >>>>>>> I just realized that requesting /ovirt-engine/api doesn't return > >>>>>>> any information about bookmarks. Where did bookmarks go? Is it > >>>>>>> possible to manage bookmarks through REST API? > >>>>>>> > >>>>>>> Note: WebAdmin currently gets bookmarks through GWT RPC by calling > >>>>>>> GetAllBookmarksQuery. Bookmark seems like proper backend business > >>>>>>> entity (with DAO and everything) so it should be exposed also via > >>>>>>> REST API.. or am I missing something? > >>>>>>> > >>>>>>> Thanks, > >>>>>>> Vojtech > >>>>>>> > >>>>>> > >>>>>> The didn't go anywhere, just never existed in the API. Please open a > >>>>>> RFE > >>>>>> to add them. > >>>>> > >>>>> Thanks, Juan. The RFE is here: > >>>>> > >>>>> https://bugzilla.redhat.com/1075556 > >>>>> > >>>>>> > >>>>>> -- > >>>>>> Dirección Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3, planta > >>>>>> 3ºD, 28016 Madrid, Spain > >>>>>> Inscrita en el Reg. Mercantil de Madrid – C.I.F. B82657941 - Red Hat > >>>>>> S.L. > >>>>>> > >>>>> _______________________________________________ > >>>>> Engine-devel mailing list > >>>>> Engine-devel@ovirt.org > >>>>> http://lists.ovirt.org/mailman/listinfo/engine-devel > >>>>> > >>>> _______________________________________________ > >>>> Engine-devel mailing list > >>>> Engine-devel@ovirt.org > >>>> http://lists.ovirt.org/mailman/listinfo/engine-devel > >>>> > >>> > >> > > _______________________________________________ > > Engine-devel mailing list > > Engine-devel@ovirt.org > > http://lists.ovirt.org/mailman/listinfo/engine-devel > > > > _______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
