Moti Asayag has posted comments on this change. Change subject: core: Add Task Manager Tables ......................................................................
Patch Set 2: (1 inline comment) .................................................... File backend/manager/dbscripts/upgrade/03_01_0160_add_job_subject_entity_table.sql Line 13: CONSTRAINT pk_jobs_subject_entity PRIMARY KEY(job_id,entity_id,entity_type) I have several issues with that: 1.readability: the audit log table will be overloaded with steps messages - do we care to have an event for successed can-do-action? 2. The audit_log table is quite big, having it store the events will cause some penalty (insert/select) which could be reduced by using partition by the range of the audit_log_types of the steps. 3. upon clearing the job/step, entries will left on the audit_log table, not sure it is required. -- To view, visit http://gerrit.ovirt.org/1083 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib662f58d8a739b1fa44f4c4ec25f053923178fc0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
