Yair Zaslavsky has posted comments on this change. Change subject: core: Task Manager Add Tables ......................................................................
Patch Set 3: (2 inline comments) .................................................... File backend/manager/dbscripts/upgrade/03_01_0210_add_job_subject_entity_table.sql Line 18: DROP INDEX if exists idx_job_subject_entity_entity_id; Why not insert the create index part to the "if" block. If you do that, no need to call the "drop index if exists" .................................................... File backend/manager/dbscripts/upgrade/03_01_0220_add_step_table.sql Line 27: DROP INDEX if exists idx_step_job_id; Same question as in previous file about the indices. -- To view, visit http://gerrit.ovirt.org/1083 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib662f58d8a739b1fa44f4c4ec25f053923178fc0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
