Omer Frenkel has posted comments on this change.
Change subject: engine : Hotplug - vdsbroker changes
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/HotPlugDiskVDSParameters.java
Line 39: return String.format("vdsId = %s vmId = %s volumeId = %s",
getVdsId(), getVmId(), diskImage.getId());
why not use super? like: return String.format("%s, volumeId=%s",
super.toString(), diskImage.getId())
....................................................
Commit Message
Line 9: This change is dine on vdsBroker level in order to allow an rpc call
with a new verb for vdsm
typo here, should be 'done'
--
To view, visit http://gerrit.ovirt.org/1634
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I18825e102a9d8e1f95872dda22b94036f5eeb364
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
