Omer Frenkel has posted comments on this change.
Change subject: engine : Hotplug - vdsbroker changes
......................................................................
Patch Set 2: (3 inline comments)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotPlugDiskVDSCommand.java
Line 38: // drive.put("address",
getParameters().getVmDevice().getAddress());
why do we need these comments?
Line 42: drive.put("iface", "virtio");
although currently only virtio is allowed, i think its better to set this from
the disk rather than hardcoding it
Line 43: drive.put("shared", Boolean.FALSE.toString());
maybe add a todo to change these (shared and optional) to the values from vm
device once its implemented
--
To view, visit http://gerrit.ovirt.org/1634
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I18825e102a9d8e1f95872dda22b94036f5eeb364
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
