Michael Kublin has posted comments on this change. Change subject: core: Add ExecutionMessageDirector for job messages ......................................................................
Patch Set 2: (3 inline comments) .................................................... File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/job/ExecutionMessageDirector.java Line 41: */ Not necessary, but if there are will be another patch please use EnumHashMap Line 46: */ same here Line 73: STEP_MESSAGE_PREFIX); maybe it is better to continue and load left messages, even if we have a problematic key, at any case a Backend bean will finish init and application will start -- To view, visit http://gerrit.ovirt.org/1303 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I567d547608e6825336fad91e14d11c5f73fa8024 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
