Michael Kublin has submitted this change and it was merged.
Change subject: core: Add ExecutionMessageDirector for job messages
......................................................................
core: Add ExecutionMessageDirector for job messages
The patch adds the ExecutionMessageDirector, a class which is
responsible for reading the job/step messages from a resource bundle by
a key identifies the message.
.
The messages keys are categorized as Job or Step level:
1. Job level: job.VdcActionType=message
The job key combines the "job." prefix with the action type which the
job describes.
2. Step level: step.StepEnum=message
The step key combines the "step." prefix with the step name as appears
in the StepEnum.
The resource bundle for the message is provided as well, were few
actions and steps are described. The complete entries will be provided
in a separate patch.
Job and Step without an message will be presented as the name of enum
which is associated with them.
The message format is a text message with place holder to be replaced
with a value, such as ${AnyParam}. The provided keys should be lowered
case.
Change-Id: I567d547608e6825336fad91e14d11c5f73fa8024
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
A
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/job/ExecutionMessageDirector.java
A
backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties
A
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/job/ExecutionMessageDirectorTest.java
A
backend/manager/modules/dal/src/test/resources/InvalidJobKeyExecutionMessages.properties
A
backend/manager/modules/dal/src/test/resources/InvalidKeyExecutionMessages.properties
A
backend/manager/modules/dal/src/test/resources/InvalidStepKeyExecutionMessages.properties
A
backend/manager/modules/dal/src/test/resources/TestExecutionMessages.properties
8 files changed, 293 insertions(+), 0 deletions(-)
Approvals:
Michael Kublin: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1303
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I567d547608e6825336fad91e14d11c5f73fa8024
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
