Yair Zaslavsky has posted comments on this change.
Change subject: core: populate vm_device correctly when creating template from
VM and VM from template
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
Line 78: if
(device.getType().equalsIgnoreCase(VmDeviceType.DISK.name()) &&
device.getDevice().equalsIgnoreCase(VmDeviceType.DISK.name())) {
I think that getType in VmDevice should return the enum (fix DAO accordingly to
work with the enums), then you will be able to do the comparisson using == and
not String.equalsIgnoreCase
Line 104: VmDevice disk =
This should be device and not disk
--
To view, visit http://gerrit.ovirt.org/1829
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3cfd30014f42f68d84d68157df33e461d043ba3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
