Eli Mesika has submitted this change and it was merged. Change subject: core: populate vm_device correctly when creating template from VM and VM from template ......................................................................
core: populate vm_device correctly when creating template from VM and VM from template This patch includes fixes to Stable Device Addresses Phase 1 1) vm_device not populated correctly when creating template from VM and VM from template 2) CDROM was populated in vm_device even if iso_path in vm_static was empty 3) Refactoring resulted from 1) & 2) V2: Adding missing java doc header to public method V3: changing addManagedDevice sugnature to get specParams and flags. Change-Id: Ia3cfd30014f42f68d84d68157df33e461d043ba3 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskToVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java 5 files changed, 81 insertions(+), 32 deletions(-) Approvals: Eli Mesika: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1829 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia3cfd30014f42f68d84d68157df33e461d043ba3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
