Yair Zaslavsky has posted comments on this change. Change subject: engine-core: Fixing AddVmCommand (Review Only) ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java Line 318: new ArrayList<DiskImage>(getVmTemplate().getDiskImageMap().values())); Why do we need this? looks like this method accepts a collection, just pass the values. -- To view, visit http://gerrit.ovirt.org/2025 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I03deb982978e48b300a44680fe56e203b37c192b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jonathan Choate <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
