Omer Frenkel has posted comments on this change.
Change subject: engine-core: Fixing AddVmCommand (Review Only)
......................................................................
Patch Set 1: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
Line 128: .getId());
i guess we should call this per template disk, as this code assume all the
disks are on the same domain
Line 305: for (Guid guid : imageToDestinationDomainMap.values()) {
i am missing a check that the image template actually exist on the requested
storage domain for this image (for example, user asks to create disk 1 on
domain A but the template's image 1 only exist on domain B)
Line 568: private void ensureDomainMap() {
not sure i understand this method, so probably doc is needed here to describe
what it does
--
To view, visit http://gerrit.ovirt.org/2025
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I03deb982978e48b300a44680fe56e203b37c192b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jonathan Choate <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
