Allon Mureinik has posted comments on this change.
Change subject: core: Added filtering option to DiskImageDAO
......................................................................
Patch Set 15: No score
(2 inline comments)
Answering mkolesni's review - will be handled in new pathset.
....................................................
File
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskImageDAOTest.java
Line 249: assertEquals("VM should have two disks", 0, disks.size());
Fixed to be more readable in next patchset.
....................................................
File
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskImageDAOWrapperImplTest.java
Line 13: public class DiskImageDAOWrapperImplTest {
lpeer's instructions:
whoever will handle the hibernate DAO will fail this test and thus be forced to
implement those methods properly.
Maybe it's redundant with the main DAO test, but we both figured it's better to
be safe than sorry.
--
To view, visit http://gerrit.ovirt.org/1841
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I15aeb5732c8cc56d0a3ab681d36c33473b004560
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
