Mike Kolesnik has posted comments on this change. Change subject: core: Added filtering option to DiskImageDAO ......................................................................
Patch Set 16: (1 inline comment) .................................................... File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskImageDAOTest.java Line 241: List<DiskImage> disks = dao.getAllForVm(EXISTING_VM_ID, PRIVILEGED_USER_ID, true); In general you can extract this repetitive code to an "run & check" private method that gets different parameters, and have each test send the correct parameters. -- To view, visit http://gerrit.ovirt.org/1841 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I15aeb5732c8cc56d0a3ab681d36c33473b004560 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
