Moti Asayag has posted comments on this change. Change subject: core: Adding logic of query ......................................................................
Patch Set 1: (3 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmConfigurationBySnapshotQuery.java Line 29: VM result = new VM(); can't the response be null? if null as return value is legit for non existing snapshot, move the initialize of the VM into the condition. Line 31: new SnapshotsManager().updateVmFromConfiguration(result,configuration); is it really needed to create new instance of the manager for each query invocation ? Line 49: private static Log log = LogFactory.getLog(GetVmConfigurationBySnapshotQuery.class); please move this to the head of the class -- To view, visit http://gerrit.ovirt.org/2167 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If91ba39e332c226f31b79ceebf66452278e3493b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
