Allon Mureinik has posted comments on this change. Change subject: core: Adding logic of query ......................................................................
Patch Set 7: (2 inline comments) What, no test case? :-( .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmConfigurationBySnapshotQuery.java Line 16: * please either document it, or remove it from the javadoc Line 49: AFAIK, the java convention is to have this at the top the class. -- To view, visit http://gerrit.ovirt.org/2167 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If91ba39e332c226f31b79ceebf66452278e3493b Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
