Omer Frenkel has posted comments on this change. Change subject: engine: Add audit log messages to CRUD commands. ......................................................................
Patch Set 11: (2 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddQuotaCommand.java Line 83: return getSucceeded() ? AuditLogType.USER_ADD_QUOTA : AuditLogType.USER_FAILED_ADD_QUOTA; if the command will fail, the quota name will not be added to the audit log message, because getQuotaName() will return null, it should be set somewhere.. (ctor?) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveQuotaCommand.java Line 73: return getSucceeded() ? AuditLogType.USER_DELETE_QUOTA : AuditLogType.USER_FAILED_DELETE_QUOTA; same here for success, after the execute the quota is not in the db anymore, you should set the quota object in the command class -- To view, visit http://gerrit.ovirt.org/2094 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic2c5aadf999f70b1509621a70970cf1df915d2fd Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
