Omer Frenkel has posted comments on this change. Change subject: engine: Add audit log messages to CRUD commands. ......................................................................
Patch Set 13: Looks good to me, approved (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveQuotaCommand.java Line 53: setQuota(getQuotaDAO().getById(getParameters().getQuotaId())); why aren't you using the base infrastructure of getQuota()? if you would write: setQuotaId(parameters.getQuotaId()) you could use getQuota() here and in canDoAction instead of getting it twice from db, also use getQuotaId() instead of getParameters().getQuotaId() everywhere -- To view, visit http://gerrit.ovirt.org/2094 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic2c5aadf999f70b1509621a70970cf1df915d2fd Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
