Saggi Mizrahi has posted comments on this change. Change subject: Refactor UpdateVdsGroupCommand ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java Line 135: VdsGroupDAO vdsGroupDAO = DbFacade.getInstance().getVdsGroupDAO(); I actually tried to not change the original logic that was used. There are a few of those cases I wondered if I should use the shorter forms (like addCanDoActionMessage() ) but you can never tell if there is a minute difference between them or not. Anyway, I'm happy to see that *not* using the singleton is the preferred method. I'll change that. -- To view, visit http://gerrit.ovirt.org/2271 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I47300fec2f6f5fabdbc75e8c78332c5aef2508a2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Haim Ateya <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
