Omer Frenkel has posted comments on this change.
Change subject: Refactor UpdateVdsGroupCommand
......................................................................
Patch Set 4:
you didnt understand my comment at all. im in favour of returning false once
check is failed, i do think this make the code much readable and we have it in
some places already. what bothered me is that its not consistent, some methods,
like validateMemberVmsState, return true and false in the middle of the method,
this, i think, is wrong and hard to maintain. i think verification methods
should: look like:
verifySomethings() {
if (something) {
return false;
}
if (something) {
return false;
}
if (something) {
return false;
}
return true;
}
--
To view, visit http://gerrit.ovirt.org/2271
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I47300fec2f6f5fabdbc75e8c78332c5aef2508a2
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Haim Ateya <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
