Saggi Mizrahi has posted comments on this change.
Change subject: Refactor UpdateStoragePoolCommand
......................................................................
Patch Set 1: (7 inline comments)
Please refrain for commenting on stuff that were already bad. I'm not saying I
made the code perfect, just a bit better.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java
Line 44: getStoragePoolDAO().updatePartial(storagePool);
I did not invent that method name, it's in the original code
Line 46: if (storagePool.getstatus() != StoragePoolStatus.Up) {
I don't know, look at original code.
Line 87:
Sorry, I ran the their formatter in eclipse because maven complained about
style errors. Apparently this adds a lot of spaces. I'll fix this in eclipse.
Line 92: if (!CheckStoragePoolNameLengthValid()) {
This was an already existing function with stupid name.
Line 96: if (!valdiateComptibilityVersionChange()) {
Oops :)
Line 100: if (!isNotLocalfsWithDefaultCluster()) {
Again, original code.
Line 119: return false;
No, they kept checking against result and skipping tests.
--
To view, visit http://gerrit.ovirt.org/2275
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0978ffd7f22c19c58c8a2c6f1f9feafabb3cdf5b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
