Maor Lipchuk has posted comments on this change. Change subject: Refactor UpdateStoragePoolCommand ......................................................................
Patch Set 1: I would prefer that you didn't submit this (5 inline comments) please import the ovirt formatter to eclipse: ovirt-engine/config/engine-code-format.xml .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java Line 50: Please remove white space, this will not pass compilation tests Line 65: same here Line 79: same here Line 87: You need to add to eclipse the rhevm formatter, please import the following formatter to eclipse: ovirt-engine/config/engine-code-format.xml Line 104: addCanDoActionMessage(VdcBllMessages.VAR__ACTION__UPDATE); You are adding the update action after you already return false if you fail. On failure the action will never be set to update. -- To view, visit http://gerrit.ovirt.org/2275 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0978ffd7f22c19c58c8a2c6f1f9feafabb3cdf5b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
