Moti Asayag has posted comments on this change. Change subject: DO NOT SUBMIT core: New mechanism in CommandBase (rollback using command) ......................................................................
Patch Set 3: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java Line 178: VdcReturnValueBase result = new VdcReturnValueBase(); No need to instantiate a variable when a line under you might override it. Move the instantiate to the 'else' clause. -- To view, visit http://gerrit.ovirt.org/2374 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic734d785215de855817acf77c88cba9047b959eb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
