Yair Zaslavsky has posted comments on this change.
Change subject: DO NOT SUBMIT core: New mechanism in CommandBase (rollback
using command)
......................................................................
Patch Set 7: (8 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 147: protected VdcReturnValueBase
runInternalCommandOnRollback(VdcActionType commandType, VdcActionParametersBase
params, CommandContext ctx) {
I thought of this as a covinience method, but i dont mind to remove it.
Line 147: protected VdcReturnValueBase
runInternalCommandOnRollback(VdcActionType commandType, VdcActionParametersBase
params, CommandContext ctx) {
Done
Line 174: protected VdcReturnValueBase
checkAndPerformRollbackUsingCommand(VdcActionType commandType,
done
Line 176: CommandContext context) {
not exactly true, as there is no such CTOR.
Since there are two methods of boolean setters, I will suggest
VdcReturnValueBase result = new VdcReturnValueBase();
result.setSucceded(false);
return result;
Or even better - as the default value for _suceeded is false , we can just
return new VdcReturnValueBase();
Line 269: adjustExecutionReason();
agreed.
Line 1048: protected void startPollingAsyncTasks(Collection<Guid> taskIds) {
It is required to start polling async tasks, after the rollback child command
is executed.
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CommandExecutionReason.java
Line 6: public enum CommandExecutionReason {
Done
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionParametersBase.java
Line 28: private transient CommandExecutionReason executionReason = null;
Done
--
To view, visit http://gerrit.ovirt.org/2374
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic734d785215de855817acf77c88cba9047b959eb
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
